-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metrics that missed labels #866
Conversation
This update is required. Without the labels, the metrics won't show up in |
Thanks. |
I have try to add the test in here. If this does not suffice, I will try to add more test regarding this. |
Ok, thanks, let me have another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good - just one Q about the docker-compose changes.
Update for PR #857